Fix: Extending italic disabling to multi-line comments and python docstrings #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix inconsistent italic styling between single-line and multi-line comments in the tokenColorCustomizations settings. Previously, the italic disabling only worked for single-line comments, leaving multi-line comments and Python docstrings in italics. This change should ensure consistent non-italic styling across all comment types. Changes include: - Add string.quoted.docstring.multi pattern - Add Python-specific docstring patterns - Support both single and double quoted multi-line comments
RlxChap2
reviewed
Apr 2, 2025
| "string.quoted.docstring.multi", | ||
| "string.quoted.docstring.multi.python punctuation.definition.string.begin", | ||
| "string.quoted.docstring.multi.python punctuation.definition.string.end", | ||
| "string.quoted.docstring.multi.python constant.character.escape" |
There was a problem hiding this comment.
ig you can make the same thing with bold, quote, etc.
but this is a perfect way to do italic font 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the inconsistent italic styling between single-line and multi-line comments in the tokenColorCustomizations settings within the README file where it talks about disabling italics. When I tried that, it only disabled the italics for the single-line comments, and not the multi-line comments (both double-quoted and single-quoted). PS. I was working in python3.12 when I noticed this.
Context
I'm new to open source contributions and would appreciate any feedback on:
Changes
Thank you for taking the time to review my contribution!