Extend CDN configuration capabilities - #24
Draft
NikolaRusakov wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
As a part of broader integration with open source repositories that adapted Tolgee SDK, the content CDN language mapping and manifest.json file prevented consuming static XML files from Tolgee Platform.
https://app.tolgee.io/projects/29352/integrateproject which suggests setting up.tolgeercconfig file and pushing the currentstrings.xml, this required custom paths for real life projects.availableLocales(availableLocales)needed to be provided inTolgee.initDuring debugging session it see observed that when cached manifest option for locales wasn't provided in
Tolgee.inithttps://github.com/NikolaRusakov/tolgee-mobile-kotlin-sdk/compare/feature/add-real-world-examples#diff-89dd2512191d99f1bad25149615c5615fdee683679fe63754624194879ba2084R13-R32
The configuration would fail.
Fix for statically consumed as other formats from Tolgee Platform
val path: (language: String) -> String = { "$it.json" },allowed defining path that differs with following platform configuration: