Skip to content

chore: add migration check job to CI workflow - #3476

Merged
Anty0 merged 2 commits into
mainfrom
jirikuchynka/migration-check-ci
Feb 18, 2026
Merged

chore: add migration check job to CI workflow#3476
Anty0 merged 2 commits into
mainfrom
jirikuchynka/migration-check-ci

Conversation

@Anty0

@Anty0 Anty0 commented Feb 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a new migration-check CI job that runs ./gradlew diffChangeLog and fails if migration files are out of date
  • Reuses the backend build artifact (same as schema-check and backend-test)
  • Wired into everything-passed gate so PRs with stale migrations cannot merge

Summary by CodeRabbit

  • Chores

    • CI pipeline now includes an automated migration check that validates database migration files are up-to-date before completing builds.
  • Refactor

    • Database indexing was adjusted to change how certain activity records are indexed, improving query behavior and performance in relevant lookups.

Adds a new migration-check job that runs ./gradlew diffChangeLog and
fails if migration files are out of date, similar to the existing
schema-check job.
@coderabbitai

coderabbitai Bot commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Adds a CI "Migration Check" job to .github/workflows/test.yml to validate database migration diffs post-build, and modifies ActivityModifiedEntity to replace a single-column branch_id index with a composite index on (activity_revision_id, branch_id).

Changes

Cohort / File(s) Summary
CI Workflow Migration Validation
.github/workflows/test.yml
Adds a new "Migration Check 🗃️" job that runs after backend-build, downloads the backend build, runs ./gradlew diffChangeLog, fails if migration diffs are present, and integrates the job into the workflow's needs graph (including the final "Everything passed" aggregation).
Database index change
backend/data/src/main/kotlin/io/tolgee/model/activity/ActivityModifiedEntity.kt
Replaces existing single-column index on branch_id with a composite index on (activity_revision_id, branch_id) for ActivityModifiedEntity (index definition changed; no API signature changes).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

  • bdshadow

Poem

🐰 I hop through CI and schema lines,

Gradle hums while migration signs,
Composite indexes align the trail,
Workflow checks ensure we prevail,
A tiny rabbit cheers—no fail!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a migration check job to the CI workflow, which is the primary objective of this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jirikuchynka/migration-check-ci

Comment @coderabbitai help to get the list of available commands and usage tips.

@Anty0 Anty0 changed the title ci: add migration check job to CI workflow chore: add migration check job to CI workflow Feb 18, 2026
@Anty0
Anty0 requested review from JanCizmar and dkrizan February 18, 2026 13:53
@Anty0
Anty0 merged commit 3d184cd into main Feb 18, 2026
42 checks passed
@Anty0
Anty0 deleted the jirikuchynka/migration-check-ci branch February 18, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants