Skip to content

Conversation

pigTom
Copy link

@pigTom pigTom commented Nov 1, 2022

Execuse me, I found the code snipped is unuseful and it will cause problem, child id type is diffirent from parent node id.
we using fields which is child value to search parent table, the logic is wrong.

 for doc_id in self.es._search(
                        self.index,
                        node.parent.table,
                        fields,
                    ):

fix #352

@toluaina
Copy link
Owner

Execuse me, I found the code snipped is unuseful and it will cause problem, child id type is diffirent from parent node id. we using fields which is child value to search parent table, the logic is wrong.

 for doc_id in self.es._search(
                        self.index,
                        node.parent.table,
                        fields,
                    ):

fix #352

I think removing this will lead to other problems. I have somewhat addressed this in this commit . So this should be fixed in the main branch

@toluaina
Copy link
Owner

Can you please confirm if this is resolved now please. I strongly feel this has been fixed in the master. Apologies for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

search_phase_execution_exception is out of range for a long for postgrest varchar id

2 participants