Fix powerkit integration to create entries again#441
Closed
paule96 wants to merge 6 commits into
Closed
Conversation
Signed-off-by: Paul Jeschke <[email protected]>
…ested dictionary format because sometimes the ecoflow api is broken Signed-off-by: paule96 <[email protected]>
…subdevices. Probably can't be used for things like smarthome pannel, where I expect more then one layer of subdevices. Signed-off-by: paule96 <[email protected]>
Signed-off-by: paule96 <[email protected]>
|
Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very complicated version of supporting subdevices. I would prefer the use of concret types that have a proper subdevices implementation. This implementation is very flacky because it reliese on dictionary keys and if anything unexpected happend in the code paths that are changed the possibility of an override in that dictionary is very likely.
fixes #431
I would prefer to rollback the changes of 5d7732c#diff-146034f7ca927c81a86406814cdde349b55138044f4620ed707e946f8b3b9ac6
But the decision is up to you @tolwi