fix(delta3): silence noisy base64 decode debug logs#784
Merged
Conversation
These three except branches fired for every protobuf payload because the messages are raw protobuf, not base64-encoded. The logs flooded debug output without conveying useful information. The fall-through behavior (use raw payload) is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These three
exceptbranches indevices/internal/delta3.pyfired for every protobuf payload because the messages are raw protobuf, not base64-encoded. The logs flooded debug output without conveying useful information.The fall-through behavior (use the raw payload when base64 decoding fails) is unchanged — only the per-message
_LOGGER.debugcall is removed and replaced with a short comment explaining why.