feat: NOTAM client + parser (M5a) - #12
Open
tomassasovsky wants to merge 1 commit into
Open
Conversation
Implements milestone M5a of the authoritative zone coverage plan (data layer only; not wired into ingest yet). - NotamParser parses the EANA POST /notam/pib HTML table into ZoneData: Desde/Hasta validity (UTC), COORD GEO DMS polygons, single-coord + RDO circles, and vertical limits (GND/FT AGL/FLxxx). Tolerant regex; a NOTAM with no derivable geometry surfaces in `ungeocodable`, never silently dropped. source = notam with activeFrom/activeTo. - NotamClient fetches per FIR code (-EF -CF -VF -MF -RR) via the site's session-cookie + AJAX-header flow; fetchAllFirs merges and tolerates a single FIR outage. - Tests run against a real captured EANA fixture (1 polygon, 2 circles, 2 un-geocodable) plus a mocked-HTTP client flow. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotamParser(zones_api_client): parses EANA'sPOST /notam/pibHTML table into time-boundedZoneData—Desde:/Hasta:validity (UTC),COORD GEODMS polygons, single-coordinate +RDO <n>NMcircles, and vertical limits (GND,<n>FT AGL,FL<n>).source = notamwithactiveFrom/activeTo.ungeocodablefor review, never silently dropped.NotamClient: fetches per FIR code (-EF -CF -VF -MF -RR) via the site's session-cookie + AJAX-header flow (reverse-engineered from the live endpoint);fetchAllFirsmerges and tolerates a single-FIR outage.Plan
feat: complete, authoritative airspace zone coverage — Milestone M5a (data layer; standalone, not wired into ingest — that's M5b). Depends on M1's validity fields.
Test plan
zones_api_client:dart test— parser tested against a real captured EANA fixture (test/fixtures/notam_ef_sample.html: 1 polygon, 2 circles, 2 un-geocodable). Asserts DMS→lat/lon, RDO→radius, FL/AGL limits, and UTC validity windows.indicador→ parse; non-200 throwsNotamException;fetchAllFirsskips a failing FIR.dart analyze+dart formatclean.Notes
feat/zone-provenance-validity-fields(M1). Endpoint is an undocumented scrape (HTML shape can change) — parsing is fixture-tested and tolerant per the plan's risk note.🤖 Generated with Claude Code