token-urls - #1
Closed
tombola wants to merge 9 commits into
Closed
Conversation
Owner
Author
|
I added and then removed Also looks like my vscode was not using isort for python import sorts for some reason, so conflicted with tests, ran isort manually from cli should now pass.... |
zerolab
suggested changes
Aug 6, 2020
|
|
||
| class TokenServeView(ServeView): | ||
| def dispatch(self, request, path): | ||
| sharing_site = self.get_sharing_site(request, path) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
zerolab
reviewed
Aug 7, 2020
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| install_requires = [ | |||
| "wagtail>=2.3,<2.10", | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Nice one. Why not open a WIP PR against the main repo to get any further feedback. Will see if I can provide tests |
* Add support for Django 3.1 * Add coveralls badge to the README * Remove dependency on external mock package and use unittest.mock
* Use waglatest in GitHub action and in tox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tokenised urls, described in README.