Support Value.StrictEquals to Go.
#106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stroiman
force-pushed
the
add-value-strict-equals
branch
from
4ae15b2 to
ef25b66
Compare
tommie
requested changes
May 21, 2025
value_test.go
Outdated
| } | ||
|
|
||
| if !numberOne.StrictEquals(numberOneB) { | ||
| t.Fatalf("Number 1 and Number 1 should be strict equal") |
There was a problem hiding this comment.
Since the following assertions are independent, using t.Errorf is appropriate.
There was a problem hiding this comment.
Fixed - as well as CHANGELOG conflict.
stroiman
force-pushed
the
add-value-strict-equals
branch
from
3c217d1 to
b0b2845
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a bunch of changes, I never PR'ed - trying to rebase them into isolated PRs of independent functionality.