softlink: friendly error on WinError 1314 (no symlink privilege) - #30
Merged
Conversation
If os.symlink fails with WinError 1314 (SeCreateSymbolicLinkPrivilege not held), re-raise as a RuntimeError that points the user at the fix: enable Developer Mode, or run bootstrap from an elevated shell. Without this they get a raw OSError stack trace from the bottom of utils.py with no clue what to do. Signed-off-by: Tommy Carpenter <9419125+tommyjcarpenter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch `OSError` with `winerror == 1314` in `_softlink` and re-raise as a `RuntimeError` that tells the user how to fix it (enable Developer Mode, or run elevated). Without this, a fresh Windows machine without Developer Mode gets a raw stack trace from the bottom of `utils.py` and no hint what's wrong