add post_commands: runs after packages + file_associations - #31
Merged
Conversation
Same shape as `commands`, just sequenced at the end of the bootstrap flow instead of the start. The motivating case is a step that depends on a package already being installed — e.g. registering a font file that scoop dropped on disk but didn't put in the user font registry. Without post_commands you'd have to either: (a) bundle install + the post-install step into one cmd that does its own scoop install (and tolerate a multi-line PowerShell quoted into JSON), or (b) split the work across two bootstrap runs. Both are bad. Schema-wise, factor out the per-OS commands shape into a reusable `commands_section` definition; both `commands` and `post_commands` now reference it. Signed-off-by: Tommy Carpenter <9419125+tommyjcarpenter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The motivating case is a step that depends on a package already being installed — e.g. registering a font file that scoop dropped on disk but didn't put in the user font registry. Without `post_commands` you'd have to either bundle install + post-install into one giant cmd (multi-line PowerShell quoted into JSON, pretty miserable to maintain) or split the work across two bootstrap runs.
Order is now:
```
mkdirs → links → commands → prereq_packages → packages →
file_associations → post_commands
```
Test plan