Changes for date-filter. Example included#12
Open
manojsethi wants to merge 1 commit intotommyp:masterfrom
manojsethi:date-filter
Open
Changes for date-filter. Example included#12manojsethi wants to merge 1 commit intotommyp:masterfrom manojsethi:date-filter
manojsethi wants to merge 1 commit intotommyp:masterfrom
manojsethi:date-filter
Conversation
Owner
|
While I agree with the change in principle, I'm not going to merge as is. A lot of the diff is whitespace changes which are unnecessary and it feels like this code could be improved. I may end up refactoring the switch to be a case statement for the input which feels like a better way to approach this problem. Feel free to keep using your fork but if I do end up refactoring it and adding a date filter I'll be sure to mention your name in the commit. |
Author
|
Thanks, looking forward to improved version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Tommy,
Please review the date filter. I have added a demo as well.
Maybe you can do some good jQuery stuff than me. Hope it helps.
Cheers
Manoj