Fix MQTT service availability check in Home Assistant addon#306
Merged
Conversation
`bashio::services mqtt` performs a supervisor API call that errors with "Service not enabled" and still produced output that let the if-branch run, so the generated config contained an empty `[MQTT_INSIGHTS]` section when no Mosquitto add-on was available. Use `bashio::services.available` for a proper availability check. https://claude.ai/code/session_019CfQvHfhZLrbnThz63fDW9
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single-line modification in the shell script replaces the MQTT service availability check method from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the MQTT service availability check to use the correct Home Assistant bashio function.
Changes
bashio::services "mqtt"tobashio::services.available "mqtt"to properly check if the MQTT service is available before attempting to access its configurationDetails
The original code was using an incorrect bashio function syntax. The
bashio::services.availablefunction is the proper way to check if a service is available in Home Assistant before attempting to retrieve its configuration details. This prevents potential errors when the MQTT service is not installed or available on the system.https://claude.ai/code/session_019CfQvHfhZLrbnThz63fDW9
Summary by CodeRabbit