Remove TCP port 52500 mapping from addon configuration#313
Merged
Conversation
The add-on runs with host_network: true, so publishing 52500/tcp via ports: caused Supervisor to bind the port on the host, leaving the health check service unable to bind and erroring with EADDRINUSE. Drop the port publication and hardcode the watchdog URL to the well-known port so the watchdog still reaches the service directly over the host network.
Keep the watchdog URL using [PORT:52500] resolution and drop the changelog bullet.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughA TCP port mapping for port 52500 was removed from the add-on's configuration while UDP port mappings and the health check endpoint reference to port 52500 remain intact. This single-line deletion affects only the port exposure declarations. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the TCP port 52500 mapping from the Home Assistant addon configuration file.
Changes
52500/tcp: 52500port mapping from theportssection inha_addon/config.yamlDetails
This change removes an unused TCP port mapping from the addon's port configuration. The UDP port mappings (2220, 2222, 2223) remain unchanged.
https://claude.ai/code/session_01KG91R96CZVPk1gk9tKnB5e
Summary by CodeRabbit