Skip to content

Remove TCP port 52500 mapping from addon configuration#313

Merged
tomquist merged 2 commits into
developfrom
claude/fix-health-check-port-CqDCZ
Apr 7, 2026
Merged

Remove TCP port 52500 mapping from addon configuration#313
tomquist merged 2 commits into
developfrom
claude/fix-health-check-port-CqDCZ

Conversation

@tomquist
Copy link
Copy Markdown
Owner

@tomquist tomquist commented Apr 7, 2026

Summary

Removed the TCP port 52500 mapping from the Home Assistant addon configuration file.

Changes

  • Removed 52500/tcp: 52500 port mapping from the ports section in ha_addon/config.yaml

Details

This change removes an unused TCP port mapping from the addon's port configuration. The UDP port mappings (2220, 2222, 2223) remain unchanged.

https://claude.ai/code/session_01KG91R96CZVPk1gk9tKnB5e

Summary by CodeRabbit

  • Chores
    • Removed a TCP port mapping from add-on port configuration; UDP port mappings remain unchanged.

claude added 2 commits April 7, 2026 19:40
The add-on runs with host_network: true, so publishing 52500/tcp via
ports: caused Supervisor to bind the port on the host, leaving the
health check service unable to bind and erroring with EADDRINUSE.

Drop the port publication and hardcode the watchdog URL to the
well-known port so the watchdog still reaches the service directly
over the host network.
Keep the watchdog URL using [PORT:52500] resolution and drop the
changelog bullet.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1001c79e-9b7f-48cc-8875-9d42b013daab

📥 Commits

Reviewing files that changed from the base of the PR and between 8d62753 and 3731a9f.

📒 Files selected for processing (1)
  • ha_addon/config.yaml
💤 Files with no reviewable changes (1)
  • ha_addon/config.yaml

Walkthrough

A TCP port mapping for port 52500 was removed from the add-on's configuration while UDP port mappings and the health check endpoint reference to port 52500 remain intact. This single-line deletion affects only the port exposure declarations.

Changes

Cohort / File(s) Summary
Port Configuration
ha_addon/config.yaml
Removed TCP port mapping 52500/tcp: 52500. UDP ports (12345/udp, 1010/udp, 2220/udp, 2222/udp, 2223/udp) remain unchanged. Note: The watchdog URL still references [PORT:52500]/health despite TCP removal.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removal of the TCP port 52500 mapping from the addon configuration file. It is concise, specific, and directly reflects the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-health-check-port-CqDCZ

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomquist tomquist merged commit 9fdaa0e into develop Apr 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants