Skip to content

docs: clarify port 1010 bind on Docker for shellypro3em_old#368

Merged
tomquist merged 2 commits into
developfrom
claude/readme-port-1010-permissions
May 16, 2026
Merged

docs: clarify port 1010 bind on Docker for shellypro3em_old#368
tomquist merged 2 commits into
developfrom
claude/readme-port-1010-permissions

Conversation

@tomquist
Copy link
Copy Markdown
Owner

@tomquist tomquist commented May 16, 2026

Summary

Adds a short note to the troubleshooting entry for PermissionError on ports 1010/2220, prompted by #367.

The current bullet recommends "Use Docker", but the published image runs as the non-root astra user, so shellypro3em_old still hits EACCES on port 1010 even with network_mode: host. The note documents the two workarounds that actually work — lowering net.ipv4.ip_unprivileged_port_start on the host or running the container as root — and warns that bridge port-publishing won't help because Marstek discovery uses UDP broadcasts to the subnet address.

Test plan

  • Render the Troubleshooting section and confirm the note reads cleanly

Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated FAQ troubleshooting section with clearer guidance on resolving binding permission errors on privileged ports when running the Docker container. Added explanations for the issue and provided two mitigation approaches.

Review Change Stack

The Docker image runs as a non-root user, so binding to port 1010
fails even with network_mode: host. Note the two working workarounds
(lower net.ipv4.ip_unprivileged_port_start or run as root) and call
out that bridge port-publishing does not forward UDP broadcasts.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Warning

Rate limit exceeded

@tomquist has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 12 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9f409f03-396b-48f8-b504-dd8c81c12d4f

📥 Commits

Reviewing files that changed from the base of the PR and between dcf1815 and 98b9522.

📒 Files selected for processing (1)
  • README.md

Walkthrough

Added a troubleshooting FAQ note explaining that the Docker image running as a non-root user prevents binding privileged port 1010 with network_mode: host, and documented two mitigation options: adjusting net.ipv4.ip_unprivileged_port_start via sysctl or running the container as root.

Changes

Docker Port Binding Troubleshooting

Layer / File(s) Summary
FAQ troubleshooting note for Docker privileged port binding
README.md
Added FAQ documentation explaining that the non-root container user prevents binding privileged port 1010 with network_mode: host (PermissionError: [Errno 13]), lists sysctl mitigation via /etc/sysctl.d/, root container option, and clarifies that Docker bridge port mapping does not forward UDP broadcast required for discovery.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: clarifying Docker port binding issues for port 1010 on the shellypro3em_old device.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/readme-port-1010-permissions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The combined shellypro3em device type expands to both _old and _new
listeners, so it binds 1010 as well.
@tomquist tomquist merged commit 700f7e1 into develop May 16, 2026
13 checks passed
@tomquist tomquist deleted the claude/readme-port-1010-permissions branch May 16, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants