-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add OpenMetrics exporter (with QUIC stats) #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: testnet
Are you sure you want to change the base?
Conversation
|
@codex please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2d59e52cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
quic/quic-server.h
Outdated
| Entry res = {.total_conns = total_conns + other.total_conns, .impl_stats = impl_stats + other.impl_stats}; | ||
| res.impl_stats.mean_rtt = (total_conns * impl_stats.mean_rtt + other.total_conns * impl_stats.mean_rtt) / (total_conns + other.total_conns); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix mean RTT aggregation to use other entry
The weighted average for mean_rtt mistakenly uses impl_stats.mean_rtt for both terms, so combining two entries always ignores other.impl_stats.mean_rtt. As a result, server-level RTT stats are wrong whenever more than one connection contributes (the aggregate stays at the current entry’s RTT). This affects all aggregated stats emitted via Stats::Entry::operator+.
Useful? React with 👍 / 👎.
quic/quic-sender.cpp
Outdated
| if (period1_collected) { | ||
| const auto &stats1 = std::get<2>(period0_stats); | ||
| LOG(INFO) << "PERIOD 1 stats SUMMARY: " << stats1.dump(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log period-1 stats from the correct bucket
When emitting PERIOD 1 logs, the code reads std::get<2>(period0_stats) instead of period1_stats, so the PERIOD 1 summary/top-5 is always a duplicate of PERIOD 0. This makes the period-1 monitoring output misleading and hides its intended time window.
Useful? React with 👍 / 👎.
|
I can’t review the PR changes because commit |
|
I can’t review this PR because commit |
|
|
No description provided.