Skip to content

Conversation

@neodix42
Copy link
Member

@neodix42 neodix42 commented Feb 1, 2026

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9d2170e45

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

  • Emscripten configure will now fail: BuildMHD.cmake forces MHD_FOUND to FALSE for emscripten, but blockchain-explorer/CMakeLists.txt now hard-fails when MHD_FOUND is false, and CMakeLists.txt still unconditionally adds blockchain-explorer. This breaks the existing wasm build. Consider guarding add_subdirectory(blockchain-explorer) or skipping the fatal for USE_EMSCRIPTEN. CMake/BuildMHD.cmake:10-13, blockchain-explorer/CMakeLists.txt:14-16, CMakeLists.txt:589.
  • BuildZlib.cmake unconditionally overwrites ZLIB_* cache entries with FORCE, so callers that pass their own zlib (e.g., the wasm build script’s -DZLIB_FOUND/-DZLIB_LIBRARIES) will be ignored. This can cause cross-compile zlib mismatch or build failures. Consider only setting these when ZLIB_FOUND is not already set or skip in USE_EMSCRIPTEN. CMake/BuildZlib.cmake:143-151.
  • MSVC toolset is hardcoded inconsistently: libmicrohttpd build uses v143 + w32/VS2022, while zlib build uses v142. This will break VS2019 or VS2022 setups depending on what’s installed. Consider using ${CMAKE_VS_PLATFORM_TOOLSET} or omitting the toolset override. CMake/BuildMHD.cmake:14-31, CMake/BuildZlib.cmake:57-74.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

No issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant