Skip to content

Move bus runtime into tdactor#2178

Open
DanShaders wants to merge 3 commits intoton-blockchain:testnetfrom
DanShaders:bus-runtime-in-tdactor
Open

Move bus runtime into tdactor#2178
DanShaders wants to merge 3 commits intoton-blockchain:testnetfrom
DanShaders:bus-runtime-in-tdactor

Conversation

@DanShaders
Copy link
Collaborator

No description provided.

This was a long-overdue change.
Otherwise if someone gives start / create_child some random unregistered
bus, we will just silently do nothing.
@github-actions
Copy link

  1. 5b4f5e95 regression: valid create_child flow now hard-fails for unregistered bus types
    The new guard CHECK(bus_parents_.contains(node->type_id)); in BusRuntime.h:571 rejects buses that were never seen in register_actor.
    That breaks legitimate usage where a child bus is created only for structure/lifetime and has no actors spawning on it (example: test-runtime.cpp:367). Before this commit, such buses worked (no spawned actors, but bus could still exist).
    Suggested fix: register bus ancestry at bus creation time (start<B> and child creation path) rather than requiring prior actor registration for that exact bus type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant