-
Notifications
You must be signed in to change notification settings - Fork 32
Use sharded pub/sub #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use sharded pub/sub #163
Conversation
📊 Performance MetricsPerformance Metrics (memory storage)
Performance Metrics (postgres storage)
📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (dnsmasq storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds |
📊 Performance MetricsPerformance Metrics (memory storage)
📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (nginx storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (dnsmasq storage) ❌ Bridge service not accessible after 30 seconds |
📊 Performance MetricsPerformance Metrics (postgres storage)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Valkey storage implementation from regular Redis pub/sub to sharded pub/sub (SPUBLISH/SSUBSCRIBE). The change uses Redis hash tags {client} in channel names to ensure all client channels are routed to the same shard in a Redis cluster, which is a requirement for sharded pub/sub to work correctly.
- Updated channel naming from
client:to{client}:format with hash tags - Migrated pub/sub methods to use sharded variants (SPublish, SSubscribe, SUnsubscribe)
- Updated channel parsing logic to handle the new format
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Performance MetricsPerformance Metrics (memory storage)
Performance Metrics (postgres storage)
📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (dnsmasq storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (nginx storage) ❌ Bridge service not accessible after 30 seconds |
📊 Performance MetricsPerformance Metrics (memory storage)
Performance Metrics (postgres storage)
📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (dnsmasq storage) ❌ Bridge service not accessible after 30 seconds |
📊 Performance MetricsPerformance Metrics (memory storage)
Performance Metrics (postgres storage)
📊 Performance Metrics (dnsmasq storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (cluster-valkey storage) ❌ Bridge service not accessible after 30 seconds 📊 Performance Metrics (nginx storage) ❌ Bridge service not accessible after 30 seconds |
Setup Cluster Valkey, bridge. In 2 terminals:
Terminal 1: sending messages:
Terminal 2: receiving messeges:
All messages received.