[deprecated]Verify origin #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

callmedenchick wants to merge 24 commits into master from origin-ip-verifier

Contributor

callmedenchick commented Aug 27, 2025

No description provided.

callmedenchick force-pushed the origin-ip-verifier branch 2 times, most recently from 91cc043 to 09f6242 Compare

August 28, 2025 08:40

TrueCarry reviewed

View reviewed changes

datatype/datatype.go Outdated Show resolved Hide resolved

TrueCarry reviewed

View reviewed changes

common_test.go Outdated Show resolved Hide resolved

TrueCarry reviewed

View reviewed changes

common_test.go Outdated Show resolved Hide resolved

TrueCarry reviewed

View reviewed changes

handler.go Outdated Show resolved Hide resolved

TrueCarry reviewed

View reviewed changes

handler_cache.go Outdated Show resolved Hide resolved

TrueCarry reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

TrueCarry reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

TrueCarry reviewed

View reviewed changes

common.go Outdated Show resolved Hide resolved

callmedenchick added 9 commits

August 28, 2025 22:08


          initial commit

8b321d3


          referrer -> origin

2c84320


          use lru cache

2fe2099


          rewrite realIp

b1b484c


          fix test

bebf93a


          add CONNECT_CACHE_SIZE and CONNECT_CACHE_TTL

6f87236


          use alpine

fc6d807


          connectCache

bcaf2d4


          realIPExtractor

633e502

callmedenchick force-pushed the origin-ip-verifier branch from deac0e0 to 633e502 Compare

August 28, 2025 20:43

callmedenchick added 9 commits

August 28, 2025 23:09


          better tests

d76d6a6


          add BridgeConnectSource

d319d8d


          fix fmt

9c42d63


          rewrite lru_cache

6df10dc


          lru cache refactoring

6656f9d


          fix fmt

52fa838


          move routine cleanup

8b8a589


          fix fmt

9eb3e27


          user alpine in the second stage

5ed00bc

callmedenchick force-pushed the origin-ip-verifier branch from 6d8071c to 5ed00bc Compare

August 29, 2025 09:29

TrueCarry reviewed

View reviewed changes

common.go

    
              // newRealIPExtractor creates a new realIPExtractor with the given trusted ranges.

              func newRealIPExtractor(trustedRanges []string) (*realIPExtractor, error) {

              	ipNets, err := realclientip.AddressesAndRangesToIPNets(trustedRanges...)

Contributor

TrueCarry Aug 29, 2025

Need to add trusted connection address check

TrueCarry reviewed

View reviewed changes

handler.go Show resolved Hide resolved

TrueCarry reviewed

View reviewed changes

handler.go Outdated

    
              	storage           db

              	_eventIDs         int64

              	heartbeatInterval time.Duration

              	connectCache      *LRUCache

Contributor

TrueCarry Aug 29, 2025

Rewrite LRU cache to not have duplicates, instead it should store sessions in a way that we can easily get all sessions for given client_id

clients, _ := connectCache.getAllSessions(client_id)

TrueCarry reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

callmedenchick added 6 commits

August 29, 2025 12:34


          remove BridgeConnectSource

db919b3


          use scratch in Dockerfile

93a0bc1


          rewrite session cache

08af080


          omitempty

85b3911


          fix time format

8b5e7f2


          rewrite connection cache, add userAgent

51adbcd

callmedenchick commented

View reviewed changes

handler.go

    
              	userAgent := c.Request().Header.Get("User-Agent")

              	// Support new JSON POST format; fallback to legacy query params for backward compatibility

              	var req verifyRequest

Contributor Author

callmedenchick Sep 1, 2025

move support to the separate PR?

callmedenchick commented

View reviewed changes

handler.go

    
              }

              func (h *handler) ConnectVerifyHandler(c echo.Context) error {

Contributor Author

callmedenchick Sep 1, 2025 •

edited

Loading

Don't forget to check whether the ip (maybe origin and user agent as well) are not empty or some sort of placeholders.

callmedenchick marked this pull request as draft

September 10, 2025 13:07

callmedenchick changed the title ~~Verify origin~~ [deprecated]Verify origin

callmedenchick closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet