Skip to content

feat(node): add logging page#1902

Open
aigerimu wants to merge 1 commit intomainfrom
logging-config
Open

feat(node): add logging page#1902
aigerimu wants to merge 1 commit intomainfrom
logging-config

Conversation

@aigerimu
Copy link
Contributor

@aigerimu aigerimu commented Mar 5, 2026

closes #1818

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

To fix the formatting issues:

  1. Install necessary dependencises: npm ci
  2. Then, run this command:
    npm run fmt:some -- ecosystem/nodes/rust/logs-config.mdx

Alternatively, a maintainer can comment /fmt in this PR to auto-apply fixes in a new commit from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates—I've left a couple of suggestions in ecosystem/nodes/rust/logs-config.mdx: please apply the inline suggestions.

Comment on lines +36 to +37
### `rolling_file`

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Appender heading uses code styling

The rolling_file appender heading currently uses inline code formatting (backticks) in the H3 line (### \rolling_file`). The style guide states that headings should not use code styling except for narrow exceptions that do not apply here. Leaving code formatting in this heading harms consistency and reduces readability in generated tables of contents. Similar appender headings in the same document follow this pattern and should be adjusted consistently, but this finding’s primary location is scoped to the rolling_file` heading.

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

| `overlay` | Overlay networks |
| `overlay_broadcast` | Overlay broadcast messages |
| `rldp` | RLDP protocol (reliable large datagrams) |
| `dht` | Distributed Hash Table |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Generic concept capitalized mid-sentence

In the logger targets table, the description for dht is written as “Distributed Hash Table”, capitalizing “Hash” and “Table” within a sentence. The style guide requires generic technical concepts to remain lowercase mid-sentence (for example, “smart contract” instead of “Smart Contract”). Keeping this term fully capitalized makes casing inconsistent across the documentation. Lowercasing the generic words while preserving the acronym in the first column restores consistency with the style rules.

Suggested change
| `dht` | Distributed Hash Table |
| `dht` | Distributed hash table |

Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ecosystem > Blockchain nodes > Rust node] add how-to logging page

1 participant