fix: Remove duplicate projections #434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanc-n
commented
Aug 6, 2025
| let mut indices: Vec<usize> = Vec::with_capacity(projection.len()); | ||
|
|
||
| // Remove duplicate projections | ||
| for &name in projection { |
There was a problem hiding this comment.
This was a little difficult to keep the chaining functions as .filter().map() requires mutable + immutable borrows, .filter_map returns Options
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
crwen
reviewed
Aug 10, 2025
| let mut fixed_projection = vec![0, 1, primary_key_index]; | ||
| fixed_projection.append(&mut projection); | ||
| fixed_projection.dedup(); | ||
| fixed_projection.append(&mut indices); |
There was a problem hiding this comment.
I think this won't work. For example, when we query &["primary_key"], the fixed_projection is [0, 1, 2, 2].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Remove duplicate projections
Are these changes tested?