feat: add dictionary type for dynamic type #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
# Conflicts: # src/record/dynamic/value/mod.rs
ethe
requested changes
Aug 13, 2025
123789456ye
reviewed
Aug 14, 2025
jonathanc-n
reviewed
Aug 14, 2025
| DataType::UInt32 => dict_builder!(UInt32Type), | ||
| DataType::UInt64 => dict_builder!(UInt64Type), | ||
| _ => { | ||
| panic!( |
There was a problem hiding this comment.
We can error handle this instead of panicking, more clear. Maybe we can add a Error::Unimplemented to the record 'error.rs' file
There was a problem hiding this comment.
This is copied from arrow make_builder. Arrow dictionary key type only supports these key types original, I think it's ok to panic here. If you think it's better to do error handling here, I think we can submit another PR to modify the upper function signature.
crwen
commented
Aug 14, 2025
| ValueError::InvalidConversion("Time64Microsecond cast failed".into()) | ||
| })?; | ||
| Ok(ValueRef::Time64(arr.value(index), TimeUnit::Second)) | ||
| Ok(ValueRef::Time64(arr.value(index), TimeUnit::Microsecond)) |
There was a problem hiding this comment.
solve the bug mentioned in #460
ethe
reviewed
Aug 14, 2025
|
Is this good to go? @ethe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Add dictionary type for dynamic type.