feat: integrate aisle for metadata-driven Parquet pruning#568
Merged
Conversation
- Remove the predicate/ directory (crate was already excluded from workspace after migration to aisle) - Add eprintln diagnostics for unsupported predicates in row_filter_expr to aid debugging until proper logging is implemented - Improve comment explaining limit placement strategy between MergeStream and PackageStream
ethe
requested changes
Jan 26, 2026
src/ondisk/sstable.rs
Outdated
| if scalar_matches_column(schema, column, value) { | ||
| Some(predicate.clone()) | ||
| } else { | ||
| eprintln!( |
Member
There was a problem hiding this comment.
eprintln should be avoided, using logs or returning Result explicitly should be bnetter
src/query/stream/package.rs
Outdated
| inclusive, | ||
| } => self.evaluate_between(column, low, high, *inclusive, row), | ||
| Expr::InList { column, values } => self.evaluate_in_list(column, values, row), | ||
| Expr::BloomFilterEq { .. } | Expr::BloomFilterInList { .. } => Ok(TriState::True), |
Member
There was a problem hiding this comment.
The residual evaluation treats BloomFilterEq/InList as always true, which would produce incorrect results if these expressions were publicly available. Therefore, exposure should be restricted or true semantics should be implemented.
Member
|
Basically the direction is good, there are some blockers we should fix before we merge this. |
Collaborator
Author
|
addressed comments @ethe |
ethe
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates aisle for metadata-driven Parquet pruning, enabling significant I/O reduction for selective queries by evaluating filter predicates against Parquet metadata before reading data.
Key Changes
min_commit_ts > read_tsAPI Changes (Breaking)
Dependencies
Implementation Details
Test Plan
Future Work