feat(bench): add fusio io probes to compaction benchmark#587
Open
feat(bench): add fusio io probes to compaction benchmark#587
Conversation
ethe
reviewed
Feb 18, 2026
benches/compaction_local.rs
Outdated
| }) | ||
| } | ||
|
|
||
| async fn prepare_read_post_compaction( |
Member
There was a problem hiding this comment.
Is read_post_compaction intended to mean "first compaction observed" or "compaction quiesced"?
Member
There was a problem hiding this comment.
read_post_compaction can start measuring before compaction fully settles, so results may be noisy/inconsistent.
ethe
reviewed
Feb 18, 2026
Member
ethe
left a comment
There was a problem hiding this comment.
read_baseline/read_post_compaction can panic on valid low-ingest env configs (list_versions returned no versions), which breaks the "env-only tunable benchmark" expectation.
benches/compaction_local.rs
Outdated
| }) | ||
| } | ||
|
|
||
| async fn prepare_read_post_compaction( |
Member
There was a problem hiding this comment.
read_post_compaction can start measuring before compaction fully settles, so results may be noisy/inconsistent.
ethe
requested changes
Feb 18, 2026
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #586
Summary
Add benchmark-only Fusio IO probes for compaction/read amplification and emit the counters in the compaction benchmark JSON artifact.
What changed
ProbedLocalFs/ProbedLocalFile) to count:read_opswrite_opsbytes_readbytes_writtenssts_touched(best effort; unique.parquetpaths under/sst/)scenarios[].setup.ioscenarios[].summary.ioDbBuilder::on_durable_fs(...)so the benchmark can inject a wrapped durable FS without changing normal production behavior.2.Validation
cargo +nightly fmt --allcargo clippy -- -D warningscargo testcargo bench --bench compaction_local