feat!: Allow providing reference programs as raw pcode #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
toolCHAINZ
commented
Dec 19, 2025
toolCHAINZ
commented
- Implement loading reference programs from raw pcode strings
- Refactor specification config to support binary files or raw pcode
- Update dependency on jingle to 0.4.0 to support new features
- Introduce ReferenceProgram struct representing steps and initial memory valuation - Implement loading reference programs from binary files and raw pcode strings - Add MemoryValuation helper for managing initial memory constraints - Refactor specification config to support binary files or raw pcode - Update dependency on jingle to 0.4.0 to support new features
Split SpecificationConfig into BinaryFileSpecification and RawPcodeSpecification to clearly represent the two specification variants.
Define BinaryFileSpecification and RawPcodeSpecification models with a discriminator field `type` for improved type safety and clarity. Add detailed docstrings and helper repr methods.
Pass Rust file, line, and module path metadata separately to Python logging to enable better integration without embedding them in the message.
- Rearrange imports in Python and Rust code for clarity and consistency - Replace reference program file with raw pcode specification in examples - Adjust logging levels and output formatting for better debug info - Update bench command to handle specification variants correctly - Simplify tracing calls and improve error/info logging messages
Remove backup Cargo.toml~ file from crackers_python directory
This was referenced Dec 21, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.