Skip to content

Added custom sort logic for right window files #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AndreaDuina
Copy link

Currently in the right window of plottr-monitr python files appear first.
This is very inconvenient because they are very rarely checked and occupy a lot of space.

Images should appear first instead, such that users don't have to scroll down every time they want to check a measurement.

I added a very simple custom sort logic, which enforces the following order:

  1. Images
  2. Folder path
  3. Param dict
  4. Anything else
  5. Python files

@marcosfrenkel
Copy link
Collaborator

@AndreaDuina Thank you for the contribution, I haven't been able to test it locally just yet, but it seems that the check is an easy fix, simply specify what the return value is for the sort function and that should be it.

@AndreaDuina
Copy link
Author

AndreaDuina commented Feb 14, 2025

Should be fine now, let me know!

There are errors for higher python versions due to a missing type definition in utils/num.py, which I haven't touched, so I'm assuming you're already aware of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants