-
Notifications
You must be signed in to change notification settings - Fork 5
ci: Add Release Please automation and comprehensive CI checks #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panbanda
wants to merge
8
commits into
toon-format:main
Choose a base branch
from
panbanda:ci/setup-please-commit-workflows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ci: Add Release Please automation and comprehensive CI checks #11
panbanda
wants to merge
8
commits into
toon-format:main
from
panbanda:ci/setup-please-commit-workflows
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement automated release management using Release Please with semantic versioning and changelog generation. Add comprehensive CI pipeline for pull requests including dependency verification, security scanning, and race condition detection. Changes: - CI workflow validates PR titles, runs tests across Go 1.23-1.25, performs security scans with govulncheck, and runs linting - Release Please workflow automates version bumping, changelog generation, and major/minor tag management - go vet and race detector added to catch concurrency issues - go mod verification ensures dependency integrity Release Please will automatically: - Create release PRs based on conventional commits - Generate semantic version bumps (feat=minor, fix=patch) - Group changelog entries by type (Features, Bug Fixes, etc.) - Update v1 and v1.x tags for easy dependency pinning
alpkeskin
approved these changes
Nov 18, 2025
- Fix typo in setup-go action version (v5s -> v5) - Remove redundant test run from release workflow (already validated in CI) - Remove major/minor tag management (not used in Go ecosystem)
Keep workflow triggers consistent with main branch only
Author
|
@alpkeskin simplified it a bit and fixed some typos after seeing the last run. |
- Remove tests.yml in favor of unified ci.yml workflow - Update ci.yml to run on both main branch pushes and PRs - Fix Go version references: change 1.25 (unreleased) to 'stable' - Update test matrix to use only released Go versions (1.23, 1.24)
Go 1.25 is released, restore it to the test matrix
- Move PR title validation to pr-validation.yml - Runs only on PRs (not main branch pushes) - CI workflow now focused on tests, linting, and security
- Remove push trigger from ci.yml (redundant after PR validation) - Explicitly set branches: [main] on both workflows - CI runs when PRs target main, not on main branch pushes
|
Is this PR ready yet? @panbanda |
Author
|
@tusgino yes, I won't know if it passes until approved unfortunately. But this should work |
alpkeskin
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements automated release management using Release Please and adds comprehensive CI validation. The workflows enforce semantic versioning, automate changelog generation, and ensure code quality through multiple validation steps.
Changes
CI Workflow (
.github/workflows/ci.yml)Runs on main branch pushes and all PRs with the following jobs:
go mod verifyandgo mod tidygo vet ./...- Static analysisgo test ./...- Unit tests with coveragego test -race ./...- Race condition detectiongovulncheck ./...for vulnerability detectiongolangci-lintfor code qualityPR Validation Workflow (
.github/workflows/pr-validation.yml)Runs only on PRs:
Release Please Workflow (
.github/workflows/release.yml)Automates releases on main branch:
Configuration Files
.release-please-manifest.json- Tracks current version (starting at 0.1.0)release-please-config.json- Configures changelog sections and release behaviorRemoved Files
.github/workflows/tests.yml- Consolidated into ci.ymlBenefits
Testing
Workflows activate on this PR to demonstrate:
Once merged to main, Release Please will create the first release PR automatically.