Skip to content

fix: remove deprecated NPM config for PNPM-only project (clean) #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: remove deprecated NPM config for PNPM-only project (clean) #172

wants to merge 1 commit into from

Conversation

@psmman
Copy link

@psmman psmman commented Nov 17, 2025

Description

Clean fix for PNPM configuration issue - removes deprecated NPM setting from .npmrc file.

Problem Solved

The project uses PNPM as the package manager ("packageManager": "[email protected]") but contained a deprecated NPM-specific configuration that caused warnings:

npm warn Unknown project config "shamefully-hoist". This will stop working in the next major version of npm.

Changes Made

  • Single file change: Removed shamefully-hoist=true from .npmrc file
  • This setting is NPM-specific and doesn't apply to PNPM
  • PNPM handles dependency hoisting through its own mechanisms

Impact

  • Eliminates deprecation warnings during builds
  • Aligns configuration with PNPM-only usage
  • Zero functional impact (setting was non-functional for PNPM)
  • Future-proofs against NPM removing this deprecated option

Testing

  • Verified builds run without warnings
  • Confirmed PNPM workspace functionality unchanged
  • All existing scripts continue to work properly

File Changes

  • .npmrc - 1 line removed (deprecated configuration)

Fixes #170

@psmman
fix: remove deprecated shamefully-hoist NPM config for PNPM project
3860110 
- Remove shamefully-hoist=true from .npmrc file
- This NPM-specific setting is deprecated and causes warnings
- PNPM handles dependency hoisting differently and doesn't need this setting
- Eliminates warning: npm warn Unknown project config shamefully-hoist
- Aligns configuration with PNPM-only usage as defined in package.json

Fixes #170
@psmman psmman mentioned this pull request Nov 17, 2025
Closed
@psmman psmman force-pushed the fix/pnpm-npmrc-clean-170 branch from dfde234 to 3860110 Compare November 18, 2025 02:00
@psmman psmman closed this by deleting the head repository Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated NPM configuration for PNPM-only project

1 participant

@psmman