Skip to content

feature: translate validation keys, related to #355#368

Open
amirjani wants to merge 3 commits intotoonvanstrijp:mainfrom
amirjani:feature/translate-validation-propery
Open

feature: translate validation keys, related to #355#368
amirjani wants to merge 3 commits intotoonvanstrijp:mainfrom
amirjani:feature/translate-validation-propery

Conversation

@amirjani
Copy link

things changed

  • added test:watch for better test handling
  • added controller for testing new functionality
  • added farsi translations
  • test passed successfully

PS: I think this is not the best way to doing so, just pushing to this branch, so if any one can follow my work

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 91.856% when pulling 7eda8f5 on amirjani:feature/translate-validation-propery into 576760e on toonvanstrijp:main.

@G0maa
Copy link

G0maa commented May 22, 2024

Hello, any updates? I'm willing to contribute.

@amirjani
Copy link
Author

Hello, any updates? I'm willing to contribute.

Hello @G0maa, I completely forgot this PR :), I mentioned in the description that I believe this is not the best approach since there will be a messy code, but if you want to continue my code, feel free to do that.

@G0maa
Copy link

G0maa commented May 22, 2024

@amirjani
I'm not sure but doesn't this, fix the issue? or am I missing something.

@amirjani
Copy link
Author

@amirjani I'm not sure but doesn't this, fix the issue? or am I missing something.

it's already fixed in the newest versions. this PR also fixes that, but it's a long time since I wrote this one, and I don't remember it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants