Support limits

[parkourben99]

Fixes #173

Support sub query limits. Now that the Eloquent Eager Limit package is native in Larave 11l.

example usage:

User::with([
    'posts' => fn ($query) => $query->limit(3)
])->paginate();

[topclaudy]

Hi @parkourben99 Thank you for the PR! This package is designed to support Laravel versions prior to 11. However, the Laravel version constraint in your composer.json file would restrict compatibility with those versions.

[parkourben99]

Hi @parkourben99 Thank you for the PR! This package is designed to support Laravel versions prior to 11. However, the Laravel version constraint in your composer.json file would restrict compatibility with those versions.

I'm not sure these changes will work with previous versions of laravel, due to the recent change in laravel to support limits.

Do the tests run on previous versions?

[mpyw]

@parkourben99 @parallels999 Any updates? I'm going to abandon https://github.com/mpyw/compoships-eager-limit. I'm looking forward to this PR get merged!

[parkourben99]

@parkourben99 @parallels999 Any updates? I'm going to abandon https://github.com/mpyw/compoships-eager-limit. I'm looking forward to this PR get merged!

Apologies, I have updated this PR.

[mpyw]

@topclaudy @parallels999 We'll appreciate if you review this in your free time 😃

[parallels999]

I am not the maintainer of this package, I don't know why you ask me for a review, At most I avoid being left without support in my old apps

[parkourben99]

I am not the maintainer of this package, I don't know why you ask me for a review, At most I avoid being left without support in my old apps

Hi @parallels999 I suspect you were tagged as you reviewed this to being with.

[chrispappas]

@parkourben99 I just submitted a PR into your PR 🤯 parkourben99#1

Your changes are not backwards-compatible with older PHP versions, GH Actions test matrix was failing, so I updated the code to use older switch and function closures. Tests are passing now on my fork of your fork.

[parkourben99]

@parkourben99 I just submitted a PR into your PR 🤯 parkourben99#1

Your changes are not backwards-compatible with older PHP versions, GH Actions test matrix was failing, so I updated the code to use older switch and function closures. Tests are passing now on my fork of your fork.

Thanks @chrispappas not sure why dead versions of PHP are still being supported

[chrispappas]

@parkourben99 the linting issue failing the CI build was introduced in my PR (sorry eh 🍁), can you fix please? I'd love to get this PR landed so I can switch back to using the main repo for compoships, and not my personal fork

[chrispappas]

@topclaudy just a follow-up ping on this PR for review, when you have time. I have been using my forked branch with this change in prod for the last few weeks and it works as expected.

[topclaudy]

@parkourben99 Can you please fix the failing tests?

[parkourben99]

@parkourben99 Can you please fix the failing tests?

Looks like the failing test are due to backed enums. I have merged master into this PR.

@parallels999 I've also added support for mariadb

[topclaudy]

@parkourben99 Thanks for the update. The tests are still failing tough. Can you take a look when you have a moment?

[topclaudy]

@parkourben99 The tests are green on master 41e7979