fix:Connector fails to register with Service Discovery when using WSS (WebSocket Secure)#490
Open
wubie052 wants to merge 1 commit into
Open
fix:Connector fails to register with Service Discovery when using WSS (WebSocket Secure)#490wubie052 wants to merge 1 commit into
wubie052 wants to merge 1 commit into
Conversation
… (WebSocket Secure) topfreegames#488 fix:topfreegames#488
Contributor
Author
|
@rsafonseca Please take a look at this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connector fails to register with Service Discovery when using WSS (WebSocket Secure) #488
fix:#488
Note
Low Risk
Small state-management fix confined to the WSS/TLS listen path; low risk aside from slightly changing lifecycle signaling for TLS deployments.
Overview
Fixes a lifecycle/state bug in
WSAcceptorwhen running over WSS/TLS by settingw.running = trueafter the TLS listener is created (matching the non-TLS path).This ensures components that rely on the acceptor "running" state (e.g., registration/health checks) see the correct status when using
ListenAndServeTLS.Reviewed by Cursor Bugbot for commit 3eccbfd. Bugbot is set up for automated code reviews on this repo. Configure here.