Skip to content

feat(step): add "uv python" step #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
GideonBear wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

feat(step): add "uv python" step #1122

GideonBear wants to merge 18 commits into from

Conversation

@GideonBear
Copy link
Member

@GideonBear GideonBear commented Apr 12, 2025

What does this PR do

Adds a disabled-by-default "uv python" step, that checks for new available versions and installs them automatically.
Is this acceptable?

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 12, 2025
View reviewed changes
src/steps/generic.rs

debug!("Found latest version: {latest:?}");

// TODO: support multiple versions. Install new patch releases for each? Optionally install new minor release?

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 12, 2025
View reviewed changes
src/steps/generic.rs

impl UvPythonVersionData {
/// Returns `None` when the version is undesirable, that is when any of the following conditions is met:
/// - It's a pre-release (we don't care about pre-releases) (TODO: add an option to care about pre-releases)

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@GideonBear
Copy link
Member Author

GideonBear commented Apr 13, 2025

There are plans to add something similar within uv (astral-sh/uv#7325, astral-sh/uv#7892, astral-sh/uv#7287, astral-sh/uv#8028, astral-sh/uv#4718), but that's probably still a long time away.

@GideonBear
Copy link
Member Author

GideonBear commented May 28, 2025 •
edited
Loading

I realized that uv tool install --reinstall does not work with uv tool install --with. Potentially this is something to be added in uv itself?

@GideonBear GideonBear mentioned this pull request May 28, 2025
Closed
@GideonBear GideonBear marked this pull request as draft June 10, 2025 05:25
@GideonBear
Copy link
Member Author

GideonBear commented Jul 17, 2025

but that's probably still a long time away.

That aged badly... Astral is way quicker with this stuff than I anticipated 😂

I'll revisit this soon, to add uv python --upgrade, and maybe still a step for upgrading the major version?

@GideonBear GideonBear changed the title Add "uv python" step feat(step): add "uv python" step Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GideonBear