Add Jiosaavn source #270
Open
Add Jiosaavn source #270
+772
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ioTrackResolver & issue fixed in Deezer/Savaan when not using proxies removed newer java syntax to make compiler happy made StringCompareMirroringAudioTrackResolver easier to change/maintain rewrote StringCompareMirroringAudioTrackResolver Refactored SaavnAudioSourceManager & used proxymanager added proxy manager & applied it to deezer tidal, savaan, proxy support,
Fixed DefaultMirroringAudioTrackResolver and made it more readable
fixed a typo
…nnecessary configurations for regular users, and kept the functionality for more advanced users
Attempts to only pick out parts for a new JioSaavn PR. Conflicts: README.md application.example.yml main/src/main/java/com/github/topi314/lavasrc/deezer/DeezerAudioSourceManager.java main/src/main/java/com/github/topi314/lavasrc/deezer/DeezerAudioTrack.java main/src/main/java/com/github/topi314/lavasrc/tidal/TidalAudioTrack.java main/src/main/java/com/github/topi314/lavasrc/tidal/TidalSourceManager.java plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java plugin/src/main/java/com/github/topi314/lavasrc/plugin/config/SourcesConfig.java plugin/src/main/java/com/github/topi314/lavasrc/plugin/config/TidalConfig.java
|
@topi314 let me know if you'd like me to squash the old commits or otherwise make the history linear |
|
Should be fine |
|
@topi314 This should now be ready. I have done a few simple tests on both the plugin and the source manager itself. Please review 🫶 @WeeeeeeeeeeS You are also welcome to share your thoughts |
WeeeeeeeeeeS
reviewed
May 5, 2025
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Show resolved
Hide resolved
|
I think you forgot to add jiosaavn here https://github.com/botlabs-gg/LavaSrc/tree/jiosaavn?tab=readme-ov-file#supported-urls-and-queries and also https://github.com/botlabs-gg/LavaSrc/tree/jiosaavn?tab=readme-ov-file#lavaplayer-usage |
topi314
requested changes
May 7, 2025
main/src/main/java/com/github/topi314/lavasrc/jiosaavn/JioSaavnAudioTrack.java
Outdated
Show resolved
Hide resolved
| byte[] decryptedBytes = cipher.doFinal(encryptedBytes); | ||
| return new String(decryptedBytes); | ||
| } catch (Exception e) { | ||
| throw new FriendlyException("Failed to decrypt URL", Severity.COMMON, e); |
There was a problem hiding this comment.
shouldnt we just rethrow as RuntimeException here?
lavaplayer should wrap it in a FriendlyException for us
main/src/main/java/com/github/topi314/lavasrc/jiosaavn/JioSaavnAudioTrack.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cannibalises the JioSaavn parts of #247
The approach is a little different:
mainlibrary (e.g. the Lavalink). This can be done via theHttpConfigurableinterface. The source manager will have no concept of what a proxy isuseLocalNetworkoption. Either there is a proxy, or there isn'tStill to do: