Fix(spotify): Disable loadLyrics when disabled by config #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Spotify lyrics logic executed even if explicitly disabled via configuration.
The core problem: SpotifySourceManager implements AudioLyricsManager, causing it to be called by the LavaLyrics fallback mechanism whenever a Spotify track was loaded, even if 'lyrics-sources: spotify: false'.
This unintended invocation of loadLyrics() triggered the required logic to obtain an Account Token (checking spDc or customTokenEndpoint). If this token source was misconfigured or unavailable, it resulted in persistent 'Connection refused' errors in the logs, despite the user only enabling Spotify for audio playback.
Implementation Details: