Move magiskboot cli to argh

[yujincheng08]

No description provided.

[topjohnwu]

@yujincheng08 cuttlefish starts failing after b26d5b0

[yujincheng08]

@topjohnwu fixed

[Copilot]

Pull Request Overview

This pull request refactors various boot-related modules to adopt a new CLI interface and update type signatures for improved consistency. Key changes include:

• Changing the parameter types for payload and patch extraction functions from specialized UTF-8 types to standard string types.
• Refactoring the dtb and cpio command functions to return LoggedResult values instead of calling process exit.
• Updating the ffi bridge in lib.rs with new function signatures and removing unused functions.

Reviewed Changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
native/src/boot/payload.rs	Updated extract_boot_from_payload signature and removed Utf8CStr references.
native/src/boot/patch.rs	Modified hexpatch to accept mutable String and Utf8CStr for from/to values.
native/src/boot/lib.rs	Adjusted ffi bindings by removing unused imports and functions.
native/src/boot/dtb.rs	Changed dtb_commands to use a more structured argument approach.
native/src/boot/cpio.rs	Refactored cpio_commands to accept explicit arguments and return LoggedResult.

Files not reviewed (4)

• native/src/Android.mk: Language not supported
• native/src/boot/compress.hpp: Language not supported
• native/src/boot/magiskboot.hpp: Language not supported
• native/src/boot/main.cpp: Language not supported

Comments suppressed due to low confidence (2)

native/src/boot/payload.rs:31

• Changing the parameter types from Utf8CStr to &str removes implicit UTF-8 validation; consider adding explicit checks or conversion to ensure the input is valid UTF-8.

pub fn extract_boot_from_payload( in_path: &str, partition_name: Option<&str>, out_path: Option<&str>, ) -> LoggedResult<()> {

native/src/boot/patch.rs:105

• Changing the file parameter to a mutable String and converting it with Utf8CStr::from_string(file) may fail if the string is not valid UTF-8; ensure that invalid inputs are handled appropriately.

pub fn hexpatch(file: &mut String, from: &Utf8CStr, to: &Utf8CStr) -> bool {

[Copilot]

Using an early return within the loop may prevent processing of subsequent commands; clarify if early exit is intentional or if all commands should be processed sequentially.

Suggested change

	return Ok(cpio.exists(path));
	exists_result = Some(cpio.exists(path));