Skip to content

Update Serbian cyrillic language #8881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rammba
Copy link

@rammba rammba commented Mar 21, 2025

Hello @topjohnwu,
I've noticed that Magisk has outdated cyrillic Serbian translation so I wanted to sync it with the newest english version. I'm a native Serbian speaker who currently works on translating the official React documentation for Serbian and some other translations as well, which you can see on my profile. I hope you will accept my changes in order to help people from Serbia to use your app more fluently.

I have few questions for you:

  1. Did I miss to translate something for the Magisk app?
  2. Is there any string which is too long to be shown on the UI?
  3. Can I add a comment to .xml files mentioning my name as a translation contributor?
  4. Is it possible to add latin Serbian as a language as well? If yes, I don't know how to name the files. Should I follow locale names sr_Cyrl and sr_Latn or to name them differently?

@vvb2060
Copy link
Collaborator

vvb2060 commented Mar 22, 2025

https://github.com/rammba/Magisk/actions

enable it, when you push to master, GitHub will auto build apk. Now you can test it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants