Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that Rust builds always go through rustup proxies by updating dependency formatting, build configurations, and documentation.
- Reformats dependency definitions in Cargo.toml and enables binary stripping.
- Updates documentation to instruct users to install rustup and link the toolchain properly.
- Refactors build.py to route cargo invocations via rustup and adjust environment setups.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| native/src/Cargo.toml | Reformats library dependency definitions and changes the strip flag to true. |
| docs/build.md | Updates development instructions to use rustup and clarifies toolchain linking steps. |
| build.py | Alters the cargo invocation by setting RUSTUP_TOOLCHAIN and refactors clippy and paths. |
Comments suppressed due to low confidence (3)
native/src/Cargo.toml:67
- Enabling binary stripping may remove essential debug symbols; please confirm this change is intended for production builds rather than development.
strip = true
build.py:237
- RUSTUP_TOOLCHAIN is being set to a file system path instead of a toolchain identifier (e.g., 'stable' or 'nightly'); please verify that rustup accepts this format to ensure the proxy functions correctly.
env["RUSTUP_TOOLCHAIN"] = str(rust_sysroot)
build.py:671
- The globals for cargo and rust_bin have been removed in favor of rust_sysroot; ensure that the cargo binary is available in the system PATH when relying solely on rustup.
rust_sysroot = ndk_path / "toolchains" / "rust"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.