Conversation
yujincheng08
approved these changes
Apr 1, 2025
Collaborator
|
How about DT_PREINIT_ARRAY? |
Owner
Author
|
@yujincheng08 Right now there is no executable with |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the project to use a Rust-based elf-cleaner implementation and updates the rustup-wrapper configuration. Key changes include:
- Renaming and updating the rustup-wrapper’s Cargo.toml (name changed from "rustup_wrapper" to "rustup-wrapper" and edition bumped to "2024").
- Adding a new Rust implementation for elf-cleaner with its Cargo.toml.
- Modifying the build script to invoke the Rust implementation instead of the previous compiled binary.
Reviewed Changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/rustup-wrapper/Cargo.toml | Updated package name and edition to align with current standards. |
| tools/elf-cleaner/src/main.rs | Introduced the Rust implementation for cleaning ELF binaries. |
| tools/elf-cleaner/Cargo.toml | Added Cargo configuration for the new elf-cleaner tool. |
| build.py | Updated commands to run the Rust-based elf-cleaner and fixed naming references. |
Files not reviewed (4)
- .gitattributes: Language not supported
- .gitmodules: Language not supported
- tools/elf-cleaner/.gitignore: Language not supported
- tools/termux-elf-cleaner: Language not supported
Comments suppressed due to low confidence (2)
tools/elf-cleaner/src/main.rs:12
- Consider defining SUPPORTED_DT_FLAGS as a u64 constant to match the type of DT_FLAGS_1 values, which would eliminate the need for an inline cast and reduce potential type conversion issues.
const SUPPORTED_DT_FLAGS: u32 = elf::DF_1_NOW | elf::DF_1_GLOBAL;
tools/rustup-wrapper/Cargo.toml:1
- The package edition has been updated to '2024'. Please ensure that all dependencies and toolchain configurations are compatible with this edition update.
[package]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.