Skip to content

Use splice to pump tty to avoid userspace copying #8946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yujincheng08
Copy link
Collaborator

No description provided.

@yujincheng08 yujincheng08 requested review from Copilot and vvb2060 April 16, 2025 18:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

native/src/core/su/pts.rs:149

  • The usage of size_of here requires an explicit import; consider adding 'use std::mem::size_of' at the top of the file.
let mut buf: [MaybeUninit<u8>; size_of::<signalfd_siginfo>()] = MaybeUninit::uninit_array();

cijlam

This comment was marked as spam.

@cijlam

This comment was marked as spam.

@cijlam

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants