Refactor overlay rc load in Rust, supporting module modification of rc - #8948
Draft
Howard20181 wants to merge 14 commits into
Draft
Refactor overlay rc load in Rust, supporting module modification of rc#8948Howard20181 wants to merge 14 commits into
Howard20181 wants to merge 14 commits into
Conversation
Howard20181
marked this pull request as draft
April 17, 2025 13:01
Howard20181
marked this pull request as ready for review
April 17, 2025 17:34
Howard20181
marked this pull request as draft
April 19, 2025 15:45
Howard20181
marked this pull request as ready for review
April 19, 2025 16:30
Howard20181
changed the title
Howard20181
changed the title
Howard20181
marked this pull request as draft
July 13, 2025 23:50
Contributor
Author
|
Rebase in progress |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Collaborator
|
@Copilot Rebase it |
Owner
|
@Howard20181 any plans to finish this PR and make it mergable? |
Contributor
Author
|
I will try to finish it when I have time, but it has been a long time, and I may need to familiarize myself with the code again. |
path start with / will clean path
Unable to reproduce the issue locally; x86 SDK 24 and 25 pass unit tests. Attempting to retrieve some logs from CI. Skipping CI before synchronizing upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules' rc scripts follow these rules:
init.rc.init.rc, exceptzygote*.rcwhich will be ignored (this restriction should be removed by changing the order of injection of zygote rc because it's useful in some use case like enable 32-bit zygote in pixel 7 series).