Skip to content

Refactor overlay rc load in Rust, supporting module modification of rc#8948

Draft
Howard20181 wants to merge 14 commits into
topjohnwu:masterfrom
Howard20181:module-rc
Draft

Refactor overlay rc load in Rust, supporting module modification of rc#8948
Howard20181 wants to merge 14 commits into
topjohnwu:masterfrom
Howard20181:module-rc

Conversation

@Howard20181
Copy link
Copy Markdown
Contributor

@Howard20181 Howard20181 commented Apr 17, 2025

Modules' rc scripts follow these rules:

  1. Ignore all scripts named init.rc.
  2. Each script existing in system partitions will be replaced by modules', otherwise, it will concatenated AFTER init.rc, except zygote*.rc which will be ignored (this restriction should be removed by changing the order of injection of zygote rc because it's useful in some use case like enable 32-bit zygote in pixel 7 series).

@Howard20181 Howard20181 marked this pull request as draft April 17, 2025 13:01
@Howard20181 Howard20181 marked this pull request as ready for review April 17, 2025 17:34
@Howard20181 Howard20181 marked this pull request as draft April 19, 2025 15:45
@Howard20181 Howard20181 marked this pull request as ready for review April 19, 2025 16:30
@Howard20181 Howard20181 changed the title Support inject rc Rewrite loading overlay rc with Rust, supporting module modification of rc Apr 20, 2025
@Howard20181 Howard20181 changed the title Rewrite loading overlay rc with Rust, supporting module modification of rc Refactor overlay rc load in Rust, supporting module modification of rc Apr 20, 2025
@topjohnwu topjohnwu added the next Planned for the release *after* the next release label Apr 29, 2025
Copy link
Copy Markdown

@timscharfenort8 timscharfenort8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@Howard20181 Howard20181 marked this pull request as draft July 13, 2025 23:50
Comment thread scripts/util_functions.sh Outdated
@Howard20181
Copy link
Copy Markdown
Contributor Author

Rebase in progress
TODO: update docs

lisprz321-netizen

This comment was marked as spam.

@aviraxp
Copy link
Copy Markdown
Collaborator

aviraxp commented Mar 19, 2026

@Copilot Rebase it

@topjohnwu
Copy link
Copy Markdown
Owner

@Howard20181 any plans to finish this PR and make it mergable?

@Howard20181
Copy link
Copy Markdown
Contributor Author

I will try to finish it when I have time, but it has been a long time, and I may need to familiarize myself with the code again.

Unable to reproduce the issue locally; x86 SDK 24 and 25 pass unit tests. Attempting to retrieve some logs from CI.

Skipping CI before synchronizing upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next Planned for the release *after* the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants