Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a regression in magiskpolicy rule parsing where hyphenated SELinux identifiers (e.g., type names containing -) were incorrectly tokenized, causing syntax errors (linked to issue #9819).
Changes:
- Stop tokenizing
-inside identifiers so hyphenated type/attribute names remain a single identifier token. - Extend xperm parsing to accept range syntax encoded as a single identifier token (e.g.,
0x1234-0x5678). - Refactor xperm hex/range parsing into small helper functions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
topjohnwu
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #9819.