app: reset install method when file picker or download dialog is cancelled#9822
Open
fulvius31 wants to merge 3 commits into
Open
app: reset install method when file picker or download dialog is cancelled#9822fulvius31 wants to merge 3 commits into
fulvius31 wants to merge 3 commits into
Conversation
- Reset selected installation method when file picking or URL entry is cancelled. - Fix a bug where `RadioGroup` would trigger spurious selection events when clearing the selection programmatically. - Use a static `LiveData` to safely communicate file selection results across `ViewModel` instances after process death. - Add `onActivityCancel` to `ContentResultCallback` to properly handle activity results with no data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tapping Patch or Download selects the radio and opens the picker/dialog.
If the user cancels, the radio stays selected but no
Uriis captured, and re-tapping the same option is a no-op. the picker can't be reopened.Fix
core/BaseActivity.kt: addonActivityCancel()toContentResultCallback.apk/InstallViewModel.kt: clear the radio on cancel.apk/DownloadDialog.kt: invokeonCancelon dismiss without a valid URL.