Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only remove some hooks that are not in preserveUnused #121

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

only remove some hooks that are not in preserveUnused #121

wants to merge 7 commits into from
+47 −6

Conversation

chouchouji
Copy link

close #119

@chouchouji chouchouji force-pushed the fix-uninstall branch 2 times, most recently from 8919fd9 to 818ff26 Compare March 9, 2025 06:06
@JounQin
Copy link
Collaborator

JounQin commented Mar 20, 2025

@chouchouji Hi, some conflicts here.

toplenboren
toplenboren reviewed Mar 20, 2025
View reviewed changes
simple-git-hooks.js
const config = _getConfig(projectRoot, customConfigPath)

if (!config) {
throw ('[ERROR] Config was not found! Please add `.simple-git-hooks.js` or `simple-git-hooks.js` or `.simple-git-hooks.json` or `simple-git-hooks.json` or `simple-git-hooks` entry in package.json.\r\nCheck README for details')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to just refer to the README, cause there are a plethora of options there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are references from other parts of the code. Do you want you update README?

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the files list here are incomplete.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not good at editing error message and docs. Please complete it if you have time. Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why test codes are removed?

Copy link
Author

@chouchouji chouchouji Mar 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It failed. I had updated test code. Please check again.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae5f5ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chouchouji
Copy link
Author

@chouchouji Hi, some conflicts here.

ok, I will rebase master branch.

JounQin
JounQin requested changes Mar 21, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JounQin JounQin JounQin requested changes

@toplenboren toplenboren toplenboren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to keep some hooks after run npm uninstall simple-git-hooks
3 participants
@chouchouji @JounQin @toplenboren