Skip to content

feat: optimize the migration experience from husky #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 7, 2025

Conversation

yyz945947732
Copy link
Contributor

@yyz945947732 yyz945947732 commented Apr 7, 2025

I'm not sure if this will resolve the issues in #86 or #101, could you please take a look?

Note: path.join() is used to handle cross-platform compatibility, and { recursive: true } is used to support creating nested directories.

close #86
close #101

Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 49df9ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JounQin
Copy link
Collaborator

JounQin commented Apr 7, 2025

@yyz945947732 Please add related test cases, thanks.

@yyz945947732
Copy link
Contributor Author

I've made some updates and added a test case. Would you mind taking another look? @JounQin

@JounQin
Copy link
Collaborator

JounQin commented Apr 7, 2025

@yyz945947732 It seems there are conflicts still. Just resolved them.

@JounQin
Copy link
Collaborator

JounQin commented Apr 7, 2025

@yyz945947732 The CI is broken.

@JounQin JounQin changed the title fix: optimize the migration experience from husky. feat: optimize the migration experience from husky Apr 7, 2025
@JounQin JounQin changed the title feat: optimize the migration experience from husky feat: optimize the migration experience from husky Apr 7, 2025
@JounQin JounQin merged commit 8bb9818 into toplenboren:master Apr 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

husky -> simple-git-hooks migration Preserve existing git hooks path (core.hooksPath)
2 participants