COG-6341 feat: Add --memory-only flag to cognee-cli forget - #4697
Open
goran-radonic wants to merge 1 commit into
Open
COG-6341 feat: Add --memory-only flag to cognee-cli forget#4697goran-radonic wants to merge 1 commit into
goran-radonic wants to merge 1 commit into
Conversation
cognee.forget() and CogneeApiClient.forget() both accept a memory_only parameter, but cognee-cli forget never exposed it in either the local argparse configuration or the --api-url remote-dispatch path, making memory-only forget entirely unreachable from the CLI. Adds the flag to both paths. Also fixes an unrelated bug found in the same function: --api-url forget dispatch read args.dataset_name, a field the CLI parser never sets (its flag is --dataset), silently dropping --dataset in that mode. And adds a guard for --everything --memory-only, which previously silently ignored --memory-only and did a full destructive wipe instead (--everything has no confirmation prompt). Split out of #4694 per reviewer feedback that PR bundled unrelated concerns; extracted as its own change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added --memory-only to cognee-cli forget, was missing even though the SDK already supports it (both locally and through --api-url). Also fixed --dataset getting silently dropped in --api-url mode (wrong arg name) and made --everything --memory-only error instead of just doing a full wipe.
Acceptance Criteria
Type of Change
Screenshots
CLI only, no UI. 164 passed.
Pre-submission Checklist
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.