fix(retrieval): preserve node-set tags on graph vectors - #4827
Open
linhongyu510 wants to merge 1 commit into
Open
fix(retrieval): preserve node-set tags on graph vectors#4827linhongyu510 wants to merge 1 commit into
linhongyu510 wants to merge 1 commit into
Conversation
linhongyu510
marked this pull request as ready for review
August 29, 2026 10:45
linhongyu510
force-pushed
the
fix/propagate-nodeset-tags-4822
branch
from
August 29, 2026 16:08
6cdbe16 to
f0a6128
Compare
Signed-off-by: linhongyu510 <linhongyu510@users.noreply.github.com>
linhongyu510
force-pushed
the
fix/propagate-nodeset-tags-4822
branch
from
August 30, 2026 00:46
f0a6128 to
3833c79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4822.
Node-set tags were dropped before Triplet and EdgeType datapoints reached vector storage, so node-set-filtered graph retrieval silently returned no triplet context. This change propagates the deterministic union of endpoint node-set names through edge properties, Triplet datapoints, aggregated EdgeType datapoints, and both PostgreSQL and Neptune Analytics hybrid EdgeType payloads.
The change is limited to creation-time metadata propagation. It does not duplicate the query-time filtering work in #4078 or the lexical chunk filtering work in #4675.
Tests
uv run pytest cognee/tests/unit/tasks/storage/test_add_data_points.py cognee/tests/unit/infrastructure/databases/test_index_graph_edges.py cognee/tests/unit/infrastructure/databases/test_postgres_hybrid_batching.py cognee/tests/unit/infrastructure/databases/test_neptune_analytics_hybrid.py -q— 66 passed, 1 skippeduv run ruff check <10 changed Python files>— passeduv run ruff format --check <10 changed Python files>— passedgit diff --check origin/dev...HEAD— passedAI assistance
TRAE was used to inspect the affected storage paths, check competing pull requests, and help prepare regression tests. I reviewed the complete diff and take responsibility for the contribution.
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.