Merged
Conversation
Member
|
The changes look good, but your branch has to be rebased on top of the current |
Contributor
Author
|
Rebased, repushed. |
AlfonsoUceda
approved these changes
Mar 12, 2026
mattmenefee
added a commit
to mattmenefee/chewy
that referenced
this pull request
Mar 18, 2026
PR toptal#1003 added Ruby 4.0 support but the README still listed 3.2-3.4. Bump the documented range to 3.2-4.0 to match.
AlfonsoUceda
added a commit
that referenced
this pull request
Mar 25, 2026
* Update Elasticsearch client references for v8 gem namespaces The elasticsearch-ruby v8 gem reorganized its module hierarchy: - The transport client moved from Elasticsearch::Transport::Client to Elasticsearch::Client - Transport errors moved from Elasticsearch::Transport::Transport::Errors to Elastic::Transport::Transport::Errors Update documentation and YARD annotations to reflect these changes. * Add Chewy 7→8 / Elasticsearch 7→8 migration guide The migration guide previously only covered up to the Chewy 6→7 upgrade path. This adds a comprehensive section for users upgrading to Chewy 8 / Elasticsearch 8, covering: - Minimum Ruby (3.2) and Rails (7.2) version requirements - elasticsearch gem version bump (>= 8.14, < 9.0) - Namespace changes from elasticsearch-transport to elastic-transport - Transport logger/tracer configuration changes - Chewy.massacre / delete_all restriction due to ES 8 defaults - Elasticsearch 8 security-by-default considerations - Recommended rolling upgrade procedure Closes #1004 * Update documented Ruby compatibility to include 4.0 PR #1003 added Ruby 4.0 support but the README still listed 3.2-3.4. Bump the documented range to 3.2-4.0 to match. --------- Co-authored-by: Alfonso Uceda <alfonso.uceda@toptal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to CI matrix and relaxed gemspec requirement.
Based on local test this seems ok ... will watch CI.
Separately, I chose to leave the gemspec range open ended to allow future rubies to not need this change, but let me know if you'd prefer to lock an upper range instead (or if there was a reason to NOT yet allow 4.0)