Fix Unreal Engine plugin binaries on subfolders #417
Conversation
There was a problem hiding this comment.
Hey @maximetinu! Thank you for contributing to gitignore.io.
In order for this change to be preserved, you have to use .patch file with your change. This way it won't be rewritten during sync with original github/gitignore.
Or you can also introduce this change to the source repository here. This way it will be automatically applied to this repo as well.
|
Hello @maximetinu can you please check @deniskaber comment and adapt the PR? |
|
I forgot to mention that I did what @deniskaber suggested, I opened a PR to the source repository https://github.com/github/gitignore/blob/master/UnrealEngine.gitignore so it is automatically applied to this repo as well. This is the link to the PR: github/gitignore#3858 it's still being reviewed, it's taking long.. |
|
Understood @maximetinu |
|
Done! ✅ I have moved the new rules to the .patch file instead 🙂 |
filipechagas
dismissed
deniskaber’s stale review
The contributor applied the suggested change
|
Hey @maximetinu I was about to merge the PR and notice there's an EOL problem. Can you please fix it? |
|
Done 🙂 |
Pull Request
Thank you for contributing to @toptal/gitignore and https://www.gitignore.io.
New or update
Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.
New
.gitignoretemplateUpdate
.gitignoretemplateDetails
This fix is to ignore binaries and intermediate files deeper in the Plugins/ hierarchy, as can be seen in the next screenshot: