R1-324: ScholarshipsListingPage - Wire up Home / Overseas toggle switch JS#1148
Open
patrickcuagan wants to merge 3 commits intofeature/323-home-overseas-togglefrom
Open
R1-324: ScholarshipsListingPage - Wire up Home / Overseas toggle switch JS#1148patrickcuagan wants to merge 3 commits intofeature/323-home-overseas-togglefrom
patrickcuagan wants to merge 3 commits intofeature/323-home-overseas-togglefrom
Conversation
patrickcuagan
commented
Apr 8, 2026
| @@ -1,4 +1,4 @@ | |||
| <a class="reset{% if modifier %} reset--{{ modifier }}{% endif %}" href="{{ value.href|default:request.path }}" data-filters-reset> | |||
| <a class="reset{% if modifier %} reset--{{ modifier }}{% endif %}" href="{{ value.href|default:request.path }}{% if scholarships %}#results{% endif %}" data-filters-reset> | |||
Collaborator
Author
There was a problem hiding this comment.
This is so users are automatically scrolled to the scholarships when pressing clear search there.
patrickcuagan
commented
Apr 8, 2026
| this.closeProjectFilters(); | ||
| if (this.body.classList.contains('project-filters')) { | ||
| this.closeProjectFilters(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is so a rogue black bar doesn't appear for a split second when clicking the clear filters link.
kevinhowbrook
approved these changes
Apr 8, 2026
| @@ -1,4 +1,4 @@ | |||
| <a class="reset{% if modifier %} reset--{{ modifier }}{% endif %}" href="{{ value.href|default:request.path }}" data-filters-reset> | |||
| <a class="reset{% if modifier %} reset--{{ modifier }}{% endif %}" href="{{ value.href|default:request.path }}{% if scholarships %}#results{% endif %}" data-filters-reset> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://torchbox.atlassian.net/browse/R1-324
This PR hooks up the home/overseas toggle switch to actually filter scholarships.